DEPR: deprecate get_ftype_counts (GH18243) #20404

GGordonGordon · 2018-03-19T02:01:42Z

Deprecate NDFrame.get_ftype_counts()

closes DEPR: deprecate get_ftype_counts #18243
tests added / passed
passes git diff upstream/master -u -- "*.py" | flake8 --diff
whatsnew entry

codecov · 2018-03-19T03:16:44Z

Codecov Report

Merging #20404 into master will increase coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #20404      +/-   ##
==========================================
+ Coverage   91.79%   91.85%   +0.05%     
==========================================
  Files         152      152              
  Lines       49215    49236      +21     
==========================================
+ Hits        45179    45225      +46     
+ Misses       4036     4011      -25

Flag	Coverage Δ
#multiple	`90.24% <ø> (+0.05%)`	⬆️
#single	`41.88% <ø> (+0.03%)`	⬆️

Impacted Files	Coverage Δ
pandas/core/generic.py	`95.86% <ø> (ø)`	⬆️
pandas/core/arrays/categorical.py	`96.2% <0%> (-0.02%)`	⬇️
pandas/core/dtypes/missing.py	`91.07% <0%> (ø)`	⬆️
pandas/core/reshape/reshape.py	`100% <0%> (ø)`	⬆️
pandas/core/strings.py	`98.32% <0%> (ø)`	⬆️
pandas/core/indexes/datetimelike.py	`96.72% <0%> (ø)`	⬆️
pandas/core/base.py	`96.78% <0%> (ø)`	⬆️
pandas/core/panel.py	`97.29% <0%> (ø)`	⬆️
pandas/core/series.py	`93.84% <0%> (ø)`	⬆️
pandas/core/indexes/category.py	`97.3% <0%> (ø)`	⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17c1fad...26268d9. Read the comment docs.

jreback · 2018-03-19T10:16:37Z

pandas/core/generic.py

@@ -4707,6 +4709,45 @@ def get_ftype_counts(self):
        object:dense     1
        dtype: int64
        """
+        warnings.warn("get_ftype_counts is deprecated and will "


no need to create another function here, this is purely user facing (IOW don't create a _get_ftype_counts). keep the doc-string though.

jreback · 2018-03-19T10:17:06Z

pandas/tests/series/test_dtypes.py

@@ -64,7 +64,7 @@ def test_dtype(self):
        assert self.ts.ftypes == 'float64:dense'
        tm.assert_series_equal(self.ts.get_dtype_counts(),
                               Series(1, ['float64']))
-        tm.assert_series_equal(self.ts.get_ftype_counts(),


just assert the warning here

pep8speaks · 2018-03-20T01:59:26Z

Hello @GGordonGordon! Thanks for updating the PR.

Cheers ! There are no PEP8 issues in this Pull Request. 🍻

Comment last updated on March 27, 2018 at 02:35 Hours UTC

TomAugspurger · 2018-03-20T15:49:28Z

pandas/core/indexes/base.py

@@ -3396,8 +3396,11 @@ def map(self, mapper, na_action=None):

    def isin(self, values, level=None):
        """
+        Return a boolean array where the index values are in `values`.


Do you know where these changes are coming from? Ideally this PR will just do the deprecation.

@TomAugspurger - Appears they snuck in with that large pd file under commit 4a43815 (GH20249)

TomAugspurger

There's a large file called pd in your PR that'll need to be deleted (our fault).

TomAugspurger · 2018-03-21T01:43:04Z

Could you try merging master into your branch? We had to do some history rewriting.

________________________________ From: Grant Smith <[email protected]> Sent: Tuesday, March 20, 2018 6:27:41 PM To: pandas-dev/pandas Cc: Tom Augspurger; Mention Subject: Re: [pandas-dev/pandas] DEPR: deprecate get_ftype_counts (GH18243) (#20404) @GGordonGordon commented on this pull request.

________________________________ In pandas/core/indexes/base.py<#20404 (comment)>:

@@ -3396,8 +3396,11 @@ def map(self, mapper, na_action=None):

def isin(self, values, level=None): """ + Return a boolean array where the index values are in `values`. @TomAugspurger<https://github.com/tomaugspurger> - Appears they snuck in with that large pd file under commit 4a43815<4a43815> (GH20249) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#20404 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ABQHIv6jezZu64997O7vdorPS_qujSN2ks5tgZBtgaJpZM4SvfkK>.

Deprecate NDFrame.get_ftype_counts()

Code review changes, simplify test case

PEP8 style fix

Revert "DOC: update the Index.isin docstring (pandas-dev#20249)" This reverts commit 4a43815.

TomAugspurger · 2018-03-22T14:08:09Z

pandas/core/indexes/base.py

@@ -3396,11 +3396,8 @@ def map(self, mapper, na_action=None):

    def isin(self, values, level=None):
        """
-        Return a boolean array where the index values are in `values`.


Can you revert the changes here? Let me know if you need help with that.

@TomAugspurger - I had removed it as you had requested to only have the deprecation code in the branch / PR. So just to clarify you do want this code back in this branch but you don't want that large pr file back in the branch?

Yeah, sorry, that's exactly right. We want everything except the large pd file.

May be easiest to just re-add them manually in a new commit, rather than trying to mess with git.

Revert the revert for just the bases.py file

GGordonGordon · 2018-03-27T02:37:57Z

@TomAugspurger - I've added the bases.py changes back in but left the large pd file out per your request.

TomAugspurger · 2018-03-27T11:29:12Z

Thanks @GGordonGordon !

jorisvandenbossche · 2018-03-27T11:40:50Z

@TomAugspurger the problem with the big .pd file, was that due to our rewriting of the history? I mean, will each PR that gets updated on master have this problem? (I don't see how you would get it from merging master or rebasing on master)

TomAugspurger · 2018-03-27T11:47:51Z

I think it was because @GGordonGordon forked this branch from a master that included the big pd file. So anyone who created a branch during that ~7 hours might have the file in their PRs.

jorisvandenbossche · 2018-03-27T11:52:18Z

OK, that should be not too many PRs then :)

jreback added the Deprecate Functionality to remove in pandas label Mar 19, 2018

jreback requested changes Mar 19, 2018

View reviewed changes

jreback added this to the 0.23.0 milestone Mar 19, 2018

jreback added the Dtype Conversions Unexpected or buggy dtype conversions label Mar 19, 2018

jsexauer mentioned this pull request Mar 19, 2018

DEPR: Clean up list of deprecations from prior versions #6581

Closed

1 task

jreback mentioned this pull request Mar 19, 2018

DEPR: let's deprecate #18262

Closed

34 tasks

TomAugspurger force-pushed the master branch from ee45e05 to 7273ea0 Compare March 19, 2018 13:00

TomAugspurger reviewed Mar 20, 2018

View reviewed changes

TomAugspurger requested changes Mar 20, 2018

View reviewed changes

noemielteto and others added 5 commits March 20, 2018 22:42

DOC: update the Index.isin docstring (pandas-dev#20249)

fd811f9

DEPR: deprecate get_ftype_counts (GH18243)

4a0e2b3

Deprecate NDFrame.get_ftype_counts()

DEPR: deprecate get_ftype_counts (GH18243)

e7b8bf0

Code review changes, simplify test case

DEPR: deprecate get_ftype_counts (GH18243)

7bab84d

PEP8 style fix

DEPR: deprecate get_ftype_counts (GH18243)

59c4bff

Revert "DOC: update the Index.isin docstring (pandas-dev#20249)" This reverts commit 4a43815.

GGordonGordon force-pushed the GH18243_deprecate_get_ftype_counts branch from 4cc2d8c to 59c4bff Compare March 21, 2018 02:44

TomAugspurger reviewed Mar 22, 2018

View reviewed changes

DEPR: deprecate get_ftype_counts (GH18243)

26268d9

Revert the revert for just the bases.py file

TomAugspurger approved these changes Mar 27, 2018

View reviewed changes

TomAugspurger merged commit 687cbe2 into pandas-dev:master Mar 27, 2018

javadnoorb pushed a commit to javadnoorb/pandas that referenced this pull request Mar 29, 2018

DEPR: deprecate get_ftype_counts (GH18243) (pandas-dev#20404)

b4365e8

dworvos pushed a commit to dworvos/pandas that referenced this pull request Apr 2, 2018

DEPR: deprecate get_ftype_counts (GH18243) (pandas-dev#20404)

6521794

kornilova203 pushed a commit to kornilova203/pandas that referenced this pull request Apr 23, 2018

DEPR: deprecate get_ftype_counts (GH18243) (pandas-dev#20404)

3adfe48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DEPR: deprecate get_ftype_counts (GH18243) #20404

DEPR: deprecate get_ftype_counts (GH18243) #20404

GGordonGordon commented Mar 19, 2018

codecov bot commented Mar 19, 2018 •

edited

Loading

jreback Mar 19, 2018

jreback Mar 19, 2018

pep8speaks commented Mar 20, 2018 •

edited

Loading

TomAugspurger Mar 20, 2018

GGordonGordon Mar 20, 2018

TomAugspurger left a comment

TomAugspurger commented Mar 21, 2018 via email

TomAugspurger Mar 22, 2018

GGordonGordon Mar 23, 2018

TomAugspurger Mar 26, 2018

GGordonGordon commented Mar 27, 2018

TomAugspurger commented Mar 27, 2018

jorisvandenbossche commented Mar 27, 2018

TomAugspurger commented Mar 27, 2018

jorisvandenbossche commented Mar 27, 2018

DEPR: deprecate get_ftype_counts (GH18243) #20404

DEPR: deprecate get_ftype_counts (GH18243) #20404

Conversation

GGordonGordon commented Mar 19, 2018

codecov bot commented Mar 19, 2018 • edited Loading

Codecov Report

jreback Mar 19, 2018

Choose a reason for hiding this comment

jreback Mar 19, 2018

Choose a reason for hiding this comment

pep8speaks commented Mar 20, 2018 • edited Loading

Comment last updated on March 27, 2018 at 02:35 Hours UTC

TomAugspurger Mar 20, 2018

Choose a reason for hiding this comment

GGordonGordon Mar 20, 2018

Choose a reason for hiding this comment

TomAugspurger left a comment

Choose a reason for hiding this comment

TomAugspurger commented Mar 21, 2018 via email

TomAugspurger Mar 22, 2018

Choose a reason for hiding this comment

GGordonGordon Mar 23, 2018

Choose a reason for hiding this comment

TomAugspurger Mar 26, 2018

Choose a reason for hiding this comment

GGordonGordon commented Mar 27, 2018

TomAugspurger commented Mar 27, 2018

jorisvandenbossche commented Mar 27, 2018

TomAugspurger commented Mar 27, 2018

jorisvandenbossche commented Mar 27, 2018

codecov bot commented Mar 19, 2018 •

edited

Loading

pep8speaks commented Mar 20, 2018 •

edited

Loading